Desktop: Handle keyboard shortcuts that are skipped by CEF on Mac#4322
Desktop: Handle keyboard shortcuts that are skipped by CEF on Mac#4322timon-schelling wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a macOS-specific keyboard handler to support standard editing shortcuts (such as Cmd+A, Cmd+C, Cmd+V, etc.) and document navigation. Feedback on the implementation highlights an eager return bug in the command shortcut block that prevents other command shortcuts from being handled, as well as a non-standard shortcut mapping for document-level selection (using Option+Shift instead of Cmd+Shift). A refactoring suggestion is provided to address both issues.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Keavon
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
!build desktop (Run ID 29123173272) |
|
|
|
* Extract CEF rendered UI into a separate process and crate * Review * Review * Review * Review * Remove necessary workarounds * Block on frame copy ack * Crop and resample frames correctly * Skip blank frames * Fix deps * Fix fmt * Fix clippy warning * Review * Fix todo
timon-schelling
force-pushed
the
desktop-mac-fix-text-shortcuts
branch
from
04074bc to
fdc1475
Compare
|
!build desktop (Run ID 29329079093) |
|
|
|
1 participant
fixes #3516
depends on #4321